From: Junio C Hamano <gitster@pobox.com>
Date: Mon, 06 Aug 2012 19:57:47 GMT
Subject: Re: [PATCH] Avoid crippled getpass function on Solaris
Message-ID: <7v628vztc4.fsf@alter.siamese.dyndns.org>
In-Reply-To: <20120806193958.GA10039@sigill.intra.peff.net>

Jeff King <peff@peff.net> writes:

> ....  From my reading of
> getpassphrase, it does seem to be a drop-in replacement.
>
> So I'm OK conceptually with the patch if we can't do any better. But
> getpass still sucks. It doesn't handle echoing, and it may or may not
> fall back to reading from stdin if the tty isn't available (which is
> disastrous for remote-curl, whose stdin is speaking the remote-helper
> protocol to git). So I'd really prefer to make HAVE_DEV_TTY work with
> Solaris if we can.

Tay Ray Chuan mentioned in the thread near-by that HAVE_DEV_TTY
codepath worked for him with "FILE *" to fd conversion, I think.