From: Junio C Hamano <gitster@pobox.com>
Date: Thu, 06 Sep 2012 03:21:35 GMT
Subject: Re: [PATCH 5/9] Refactor excluded and path_excluded
Message-ID: <7v627r7s5c.fsf@alter.siamese.dyndns.org>
In-Reply-To: <CACsJy8D23tDa3SJO6yegHFs2hT+bTr6mLTn16ZU3kiT1dtj4vw@mail.gmail.com>

Nguyen Thai Ngoc Duy <pclouds@gmail.com> writes:

> We could introduce exclude_path() and kill path_excluded() then. There
> are just about 5-6 call sites to replace.

The name path_excluded(... path ...) sounds like it is asking a
yes/no question "is this path excluded?", which actually is what is
going on.

The name exclude_path(... path ...) sounds as if you are requesting
somebody to exclude the path.  Does that meaning match the semantics
of the function?