From: Junio C Hamano <gitster@pobox.com>
Date: Fri, 11 Jan 2013 16:45:17 GMT
Subject: Re: [PATCH] git-completion.bash: Silence not a valid object errors
Message-ID: <7v6233d5ya.fsf@alter.siamese.dyndns.org>
In-Reply-To: <alpine.DEB.2.02.1301110304220.26739@antec>

Dylan Smith <dylan.ah.smith@gmail.com> writes:

> Trying to complete the command
>
>   git show master:./file
>
> would cause a "Not a valid object name" error to be output on standard
> error. Silence the error so it won't appear on the command line.
>
> Signed-off-by: Dylan Smith <dylan.ah.smith@gmail.com>
> ---

Looks obviously correct.  Thanks.

>  contrib/completion/git-completion.bash |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/contrib/completion/git-completion.bash b/contrib/completion/git-completion.bash
> index 0b77eb1..d4c7bfe 100644
> --- a/contrib/completion/git-completion.bash
> +++ b/contrib/completion/git-completion.bash
> @@ -397,7 +397,7 @@ __git_complete_revlist_file ()
>  		*)   pfx="$ref:$pfx" ;;
>  		esac
>  
> -		__gitcomp_nl "$(git --git-dir="$(__gitdir)" ls-tree "$ls" \
> +		__gitcomp_nl "$(git --git-dir="$(__gitdir)" ls-tree "$ls" 2>/dev/null \
>  				| sed '/^100... blob /{
>  				           s,^.*	,,
>  				           s,$, ,