From: Junio C Hamano Date: Tue, 22 Jan 2013 06:21:10 GMT Subject: Re: [PATCH 3/3] push: further reduce "struct ref" and simplify the logic Message-ID: <7v622pd9gp.fsf@alter.siamese.dyndns.org> In-Reply-To: <1358834027-32039-4-git-send-email-gitster@pobox.com> Junio C Hamano writes: > The "update" field in "struct ref" is only used in a very narrow > scope in a single function. Remove it. > > Also simplify the code that rejects an attempted push by first > checking if the proposed update is forced (in which case we do not > need any check on our end). Actually, the latter is a bad idea; it changes the semantics and mark a push that was done with an unnecessary --force option. I'm rerolling these three patches (the "update" removal will also be moved to the preparatory clean-up patch).