From: Junio C Hamano <gitster@pobox.com>
Date: Thu, 07 Feb 2013 19:16:00 GMT
Subject: Re: [PATCH 1/4] Makefile: extract perl-related rules to make them available from other dirs
Message-ID: <7v62247x5b.fsf@alter.siamese.dyndns.org>
In-Reply-To: <1360174292-14793-2-git-send-email-Matthieu.Moy@imag.fr>

Matthieu Moy <Matthieu.Moy@imag.fr> writes:

> The final goal is to make it easy to write Git commands in perl in the
> contrib/ directory. It is currently possible to do so, but without the
> benefits of Git's Makefile: adapt first line with $(PERL_PATH),
> hardcode the path to Git.pm, ...
>
> We make the perl-related part of the Makefile available from directories
> other than the toplevel so that:
>
> * Developers can include it, to avoid code duplication
>
> * Users can get a consistent behavior of "make install"
>
> Signed-off-by: Matthieu Moy <Matthieu.Moy@imag.fr>

The goal may be worthy, but the split does not look quite right.

What business do contrib/ scripts have knowing how gitweb and
git-instaweb are built and what they depend on, for example?