From: Junio C Hamano Date: Mon, 13 May 2013 15:49:42 GMT Subject: Re: [PATCH 4/6] stash: introduce 'git stash store' Message-ID: <7v61ymop61.fsf@alter.siamese.dyndns.org> In-Reply-To: Ramkumar Ramachandra writes: > Junio C Hamano wrote: >> - The error message store_stash() gives should not be hardcoded in >> that function. >> >> Save-stash may want to keep saying 'the current status' as it >> said before, but a caller like your rebase-autostash will not be >> saving the "current" status and would want to have a different >> message. > > Makes sense. I think it is fine to have a "default" message to be used when store_stash shell function is not given an optional error message. The command line for it may become: git stash store [-m ] [-e ] $stash_sha1 or something like that.