From: Junio C Hamano Date: Fri, 28 Jun 2013 03:59:48 GMT Subject: Re: [PATCH 1/2] status: really ignore config with --porcelain Message-ID: <7v61wyrikr.fsf@alter.siamese.dyndns.org> In-Reply-To: <20130628014011.GA620@sigill.intra.peff.net> Jeff King writes: > You lose the assertion that finalize_deferred_config has been called, > but I think the resulting code would be simpler, as it drops this > die("BUG") state entirely. Am I missing something? Probably not. Depending on "-z", NONE is sometimes converted to PORCELAIN and sometimes left as-is. I originally wanted to keep the "unspecified" state as long as possible so that this deferred config logic and the "-z" default logic can be kept separate. The final patch ended up folding that "-z" default logic into the same function, so it probably is saner to remove UNSPECIFIED.