From: Junio C Hamano <junkio@cox.net>
Date: Thu, 15 Mar 2007 01:23:40 GMT
Subject: Re: [PATCH 2/5] diff --quiet
Message-ID: <7v4pon5mg3.fsf@assigned-by-dhcp.cox.net>
In-Reply-To: <Pine.LNX.4.64.0703141728350.9690@woody.linux-foundation.org>

Linus Torvalds <torvalds@linux-foundation.org> writes:

> On Wed, 14 Mar 2007, Junio C Hamano wrote:
>
>> "Alex Riesen" <raa.lkml@gmail.com> writes:
>> 
>> > Now I'm happy :)
>> >
>> > ~/linux$ time git diff-tree -r -s v2.6.16 v2.6.20
>> >
>> > real    0m0.137s
>> > user    0m0.117s
>> > sys     0m0.020s
>> > ~/linux$ time ~/projects/git-diff/git-diff-tree -r --quiet v2.6.16 v2.6.20
>> >
>> > real    0m0.006s
>> > user    0m0.000s
>> > sys     0m0.007s
>> 
>> You do not need diff-tree --quiet to do that!
>> 
>> 	$ git-rev-parse v2.6.16^{tree} v2.6.20^{tree}
>
> Well, if you have a path-spec, it can certainly matter.
>
> Personally, I think it's more interesting if this can make a difference 
> for something like
>
> 	git log v2.6.12.. -- drivers/ > /dev/null
>
> but that would require that we actually understand that we can stop early 
> if we ever get to REV_TREE_DIFFERENT. I didn't check if you actually did 
> that optimization.

The code is supposed to be there, but I haven't benched.