From: Junio C Hamano <junkio@cox.net>
Date: Wed, 11 Apr 2007 07:55:29 GMT
Subject: Re: sscanf/strtoul: parse integers robustly
Message-ID: <7v4pnnqr9q.fsf@assigned-by-dhcp.cox.net>
In-Reply-To: <871witxicn.fsf@rho.meyering.net>

Jim Meyering <jim@meyering.net> writes:

> diff --git a/git-compat-util.h b/git-compat-util.h
> index 139fc19..5f6a281 100644
> --- a/git-compat-util.h
> +++ b/git-compat-util.h
> @@ -301,4 +301,17 @@ static inline int prefixcmp(const char *str, const char *prefix)
>  	return strncmp(str, prefix, strlen(prefix));
>  }
>  
> +static inline int strtoul_ui(char const *s, int base, unsigned int *result)
> +{
> +	unsigned long ul;
> +	char *p;
> +
> +	errno = 0;
> +	ul = strtoul(s, &p, base);
> +	if (errno || *p || p == s || (unsigned int) ul != ul)
> +		return -1;
> +	*result = ul;
> +	return 0;
> +}
> +
>  #endif

War on sscanf is fine, but I wonder if this is small enough to
be a good candidate for inlining.