From: Junio C Hamano <gitster@pobox.com>
Date: Sun, 16 Sep 2007 00:56:49 GMT
Subject: Re: [PATCH] builtin-apply: use strbuf's instead of buffer_desc's.
Message-ID: <7v4phv8m26.fsf@gitster.siamese.dyndns.org>
In-Reply-To: <20070915141340.334CA4C152@madism.org>

Pierre Habouzit <madcoder@debian.org> writes:

>  1 files changed, 73 insertions(+), 130 deletions(-)

Nice reduction.

> -		}
> -		return got != size;
> +
> +		nsize = buf->len;
> +		nbuf = convert_to_git(path, buf->buf, &nsize);
> +		if (nbuf)
> +			strbuf_embed(buf, nbuf, nsize, nsize);
> +		return 0;


I suspect that changing the convert_to_git() interface to work
on strbuf instead of (char*, size_t *) pair might make things
simpler and easier.