From: Junio C Hamano <gitster@pobox.com>
Date: Sat, 12 Jan 2008 19:17:15 GMT
Subject: Re: [PATCH 3/5] git-submodule: New subcommand 'summary' (3) - limit summary size
Message-ID: <7v4pdiua4k.fsf@gitster.siamese.dyndns.org>
In-Reply-To: <46dff0320801120151s7959edddp1e1f8b506da79e4e@mail.gmail.com>

"Ping Yin" <pkufranky@gmail.com> writes:

> On Jan 12, 2008 4:36 PM, Junio C Hamano <gitster@pobox.com> wrote:
>> Ping Yin <pkufranky@gmail.com> writes:
>>
>> > @@ -265,6 +267,10 @@ set_name_rev () {
>> >  #
>> >  modules_summary()
>> >  {
>> > +     summary_limit=${summary_limit:-1000000}
>>
>> Why a million?
> Because i think a million is big enough. I'd better define a constant
> for unlimited number.

I think that is a wrong approach to begin with.  You are
assuming that you will always limit and by using improbably
large limit to pretend it is unlimited.  Why not making the
summary list generator truely capable of produce an unlimited
list?

I also think using 100 or so as a sane default, allowing the
user to override to say "I do not want any limitation", is a
much better default.