From: Junio C Hamano Date: Sat, 23 Aug 2008 00:12:53 GMT Subject: Re: About git pretty Message-ID: <7v4p5c612y.fsf@gitster.siamese.dyndns.org> In-Reply-To: "David Tweed" writes: > On Sat, Aug 23, 2008 at 12:41 AM, Junio C Hamano wrote: >> "Felipe Contreras" writes: >>> It is just me or 'pretty full' doesn't exactly convey the meaning of >>> the action to execute? > [snip] >>> If you like the idea I can work on a patch. >> >> FWIW, I don't like it. > > It's probably much too late to change conventions given the number of > deployed scripts, but one of the annoyances for me about git is that a > lot of the commands/options names are based on what the code does/is > written rather than relating to what a user who doesn't know or care > about the inner workings expects as output. For instance, I imagine > the --pretty gets its name because a pretty printing routine, called > pretty_print_commit in the code,... It's the other way around. We name function pretty_print_commit() because we would want to pretty print out output and the option to trigger the behaviour then is named --pretty.