From: Junio C Hamano Date: Sat, 11 Oct 2008 11:28:46 GMT Subject: Re: Adding Reviewed-by/Tested-by tags to other peoples commits Message-ID: <7v4p3jl6a9.fsf@gitster.siamese.dyndns.org> In-Reply-To: <20081011074604.GA23883@sigill.intra.peff.net> Jeff King writes: > On Sat, Oct 11, 2008 at 07:37:04AM +0100, Alex Bennee wrote: > >> I've just tested/reviewed a patch of someone elses and I want to >> forward it on the appropriate mailing list. I gather for Linux you >> just add the appropriate tags to the commit. Does git offer a shortcut >> for doing this or do you have to do a reset HEAD^ and re-commit with a >> copy&pasted and modified commit message? > > Try "git commit --amend" to edit the commit message. There's no > automatic way of adding acked-by or tested-by tags with git; most people > who do those things often would probably configure their editor to make > it easier. These Distimmed-by: fields are cumulative in nature, so once recorded in a commit log message you cannot add new ones without amending, which means you cannot exchange such commits by pushing or pulling but by forwarding patches via e-mails. I thought people added these in their MUAs. IOW, I share your "would probably" with s/editor/MUA/.