From: Junio C Hamano <gitster@pobox.com>
Date: Fri, 13 Feb 2009 17:49:15 GMT
Subject: Re: [Virtual PATCH] Add an option to wrap a patch in <pre> in git-imap-send which ironically results in a cleaner patch from Thunderbird.
Message-ID: <7v4oyy9qhw.fsf@gitster.siamese.dyndns.org>
In-Reply-To: <49955860.80504@drmicha.warpmail.net>

Michael J Gruber <git@drmicha.warpmail.net> writes:

>> What worries me the most is if there is any guarantee that this bug you
>> are exploiting to force it to send a patch in the common denominator
>> format _will not be fixed_ in future versions of Thunderbird.
>
> It's not a bug, it's a feature ;)
>
> In fact it really is: preformatted text in HTML (<pre>) is by definition
> left alone. Now, when you are about to send an HTML mail TB asks you
> what to do (or takes a choice from preferences/addressbook): send as
> HTML, as text or both.

Ok, "TB asks you what to do and you choose 'text-only'" is the part I
missed.  In that case, I'd agree it definitely is a feature not to use
flowed to convert that <pre>..</pre> to a plain text.  Thanks for an
explanation.

>> I see your patch deals only with ampersand, less-than, greater-than and
>> dquot.  Do you know if this is enough, or would letters outside US-ASCII
>> need to be expressed in ampersand-hash "character reference" notation?
>
> According to Ben of Mozilla fame this is enough for special characters.
> I don't know about UTF-8, though. Usually, TB recognizes the proper
> encoding.

Yeah, anything outside US-ASCII.  That was what I was wondering about.