From: Junio C Hamano <gitster@pobox.com>
Date: Sat, 14 Feb 2009 02:02:51 GMT
Subject: Re: [PATCH 1/2] Clean up use of ANSI color sequences
Message-ID: <7v4oyx4vxw.fsf@gitster.siamese.dyndns.org>
In-Reply-To: <1234562021-2397-1-git-send-email-arjen@yaph.org>

Arjen Laarhoven <arjen@yaph.org> writes:

> diff --git a/pretty.c b/pretty.c
> index cc460b5..a8595f6 100644
> --- a/pretty.c
> +++ b/pretty.c
> @@ -567,16 +567,16 @@ static size_t format_commit_item(struct strbuf *sb, const char *placeholder,
>  			return end - placeholder + 1;
>  		}
>  		if (!prefixcmp(placeholder + 1, "red")) {
> -			strbuf_addstr(sb, "\033[31m");
> +			strbuf_addstr(sb, COLOR_RED);
>  			return 4;
>  		} else if (!prefixcmp(placeholder + 1, "green")) {
> -			strbuf_addstr(sb, "\033[32m");
> +			strbuf_addstr(sb, COLOR_GREEN);
>  			return 6;
>  		} else if (!prefixcmp(placeholder + 1, "blue")) {
> -			strbuf_addstr(sb, "\033[34m");
> +			strbuf_addstr(sb, COLOR_BLUE);
>  			return 5;
>  		} else if (!prefixcmp(placeholder + 1, "reset")) {
> -			strbuf_addstr(sb, "\033[m");
> +			strbuf_addstr(sb, COLOR_RESET);

These four are obviously bad and not even compile tested.

I'll fix them up when queuing.