From: Junio C Hamano <gitster@pobox.com>
Date: Thu, 26 Feb 2009 23:29:39 GMT
Subject: Re: [PATCH] t5540-http-push.sh: avoid non-portable grep -P
Message-ID: <7v4oygrd3w.fsf@gitster.siamese.dyndns.org>
In-Reply-To: <76718490902261440p4c9981fbncbdd58ad12e38349@mail.gmail.com>

Jay Soffian <jaysoffian@gmail.com> writes:

> On Thu, Feb 26, 2009 at 5:37 PM, Junio C Hamano <gitster@pobox.com> wrote:
>> I don't mind Perl as we already depend on it; the looseness of the regexp
>> stil bothers me somewhat, though...
>
> I think you're letting the perfect be the enemy of the good. The point
> of the test is merely to check for the SHA-1 has suffix in PUT/MOVE
> operations. Any of my suggestions so far are better than what is there
> now. Why so much fuss?
>
> I'll send one more iteration, and if that's not good enough, I give up.
>
> j.

Heh, at least with /a-z/a-f/, I think it is usable.

Or is there a reason I am missing that we want to allow g-z there?