From: Junio C Hamano Date: Thu, 16 Apr 2009 16:52:50 GMT Subject: Re: [PATCH] Add the diff option --no-defaults Message-ID: <7v4owok0bh.fsf@gitster.siamese.dyndns.org> In-Reply-To: <20090416094154.GA30479@coredump.intra.peff.net> Jeff King writes: > On Thu, Apr 16, 2009 at 11:25:08AM +0200, Johannes Schindelin wrote: > >> > This feels very hack-ish to me, but perhaps this is a case of "perfect >> > is the enemy of the good". >> >> I have a strong feeling that none of our diff/rev options can sanely take >> a parameter looking like "--defaults" or "--no-defaults". >> >> But I do not have the time to audit the options. Maybe you have? > > Right now, I think we are safe. A few options like "--default" do take a > separated string argument, but saying "--default --no-defaults" seems a > little crazy to me (besides being confusing because they are talking > about two totally unrelated defaults). Maybe you guys have already considered and discarded this as too hacky, but isn't it the easiest to explain and code to declare --no-defaults is acceptable only at the beginning?