From: Junio C Hamano Date: Fri, 30 Oct 2009 22:33:16 GMT Subject: Re: [PATCH] Changed timestamp behavior of options -c/-C/--amend Message-ID: <7v4opgh5qr.fsf@alter.siamese.dyndns.org> In-Reply-To: <55bacdd30910301520h2678d0c2hd8478716d8ce4a17@mail.gmail.com> Erick Mattos writes: > 2009/10/30 Junio C Hamano : >> Junio C Hamano writes: >> >>> ... >>> I agree that the issue the patch addresses is worth improving, and I think >>> it is sensible to default to reuse the timestamp for -C and not to reuse >>> for --amend.  I am not sure about -c myself, but it probably shouldn't >>> reuse the timestamp by default. >> >> So after realizing that this was about "author" timestamp, I am rescinding >> this comment about the change of the default for -c and --amend. > > Actually I am only changing the default for -c and I see it useful. > At least with me I normally use -c only to use messages of commits as > template. I do that from time to time as well. As I said in a different message, it may make the default more intutitive if we give new timestamp when the author is the same as the committer when doing "-c". You are creating your own commit in that case.