From: Junio C Hamano <gitster@pobox.com>
Date: Wed, 16 Mar 2011 19:47:57 GMT
Subject: Re: [PATCH 4/8] vcs-svn: remove spurious semicolons
Message-ID: <7v4o72979u.fsf@alter.siamese.dyndns.org>
In-Reply-To: <20110316070242.GE5988@elie>

Jonathan Nieder <jrnieder@gmail.com> writes:

> trp_gen is not a statement or function call, so it should not be
> followed with a semicolon.  Noticed by gcc -pedantic.
>
>  vcs-svn/repo_tree.c:41:81: warning: ISO C does not allow extra ';'
>   outside of a function [-pedantic]
> ...
> diff --git a/vcs-svn/repo_tree.c b/vcs-svn/repo_tree.c
> index 491f013..207ffc3 100644
> --- a/vcs-svn/repo_tree.c
> +++ b/vcs-svn/repo_tree.c
> @@ -38,7 +38,7 @@ static uint32_t mark;
>  static int repo_dirent_name_cmp(const void *a, const void *b);
>  
>  /* Treap for directory entries */
> -trp_gen(static, dent_, struct repo_dirent, children, dent, repo_dirent_name_cmp);
> +trp_gen(static, dent_, struct repo_dirent, children, dent, repo_dirent_name_cmp)

Yuck.  Correct but ugly.