From: Junio C Hamano Date: Thu, 28 Apr 2011 20:52:03 GMT Subject: Re: [RFC/PATCH] completion: avoid "words" as variable name for zsh portability Message-ID: <7v4o5i3xqk.fsf@alter.siamese.dyndns.org> In-Reply-To: Felipe Contreras writes: > Nice! Much better approach. > > I also noticed that behavior when not defining 'words' as local, but > though modifying all those instances was overkill. > > Acked-by: Felipe Contreras Do you mean reviewed-by or even better tested-by?