From: Junio C Hamano Date: Fri, 29 Apr 2011 21:47:03 GMT Subject: Re: [PATCH RESEND] git-svn: don't confuse editors with an apostrophe Message-ID: <7v4o5gwx0o.fsf@alter.siamese.dyndns.org> In-Reply-To: <20110429205130.GA2727@bee.lab.cmartin.tk> Carlos Martín Nieto writes: > It's not the output of the tool, it's the perl script. It uses the cat > << EOF trick/method so ... Ahhhhh (a lightbulb dimly lits, and then explodes). As it is generally a bad practice to cater to those who edit this file by changing the output that is served to the end user, _unless_ the updated output clearly gives a better experience to the end user [*1*], it never occurred to me that that is what you are doing in this patch. Yes, the message should be made clearer. Thanks for an explanation. [Footnote] *1* In other words, updating the output to help users is fine. And if such a change unconfuses your editor, that would be a nice side effect. Doing things the other way around is simply the tail wagging the dog.