From: Junio C Hamano <gitster@pobox.com>
Date: Tue, 10 May 2011 06:11:25 GMT
Subject: Re: [PATCH v3 6/6] git-grep: Bail out when -P is used with -F or -E
Message-ID: <7v4o53m6eq.fsf@alter.siamese.dyndns.org>
In-Reply-To: <20110510072439.6b288715@mkiedrowicz>

Michal Kiedrowicz <michal.kiedrowicz@gmail.com> writes:

>> We would need some tests for "grep -P", no?  
>
> What about those in patch 5/6?

There are some, but we would also want to see negative cases where
compilation detects an incorrect regexp.

>> Please throw in the
>> "last one wins" and "command line defeats configuration" when you add
>> one.

> +test_expect_success LIBPCRE 'grep -P -i pattern' '
>
> in patch 5/6 :). Or perhaps it doesn't work for you?

These I overlooked.  Will remove the "-i -P does not work yet".

Thanks.