From: Junio C Hamano Date: Mon, 12 Dec 2011 08:13:09 GMT Subject: Re: [PATCH 1/3] Convert resolve_ref+xstrdup to new resolve_refdup function Message-ID: <7v4nx68ay2.fsf@alter.siamese.dyndns.org> In-Reply-To: Nguyen Thai Ngoc Duy writes: > Yeah that slipped in. It should be part of c689332 (Convert many > resolve_ref() calls to read_ref*() and ref_exists() - 2011-11-13). I > guess either I missed it or it was a new call site after that patch. > Split it out as a separate patch? Yeah, I think it makes sense to split the unrelated part out and place it early in the series. It seems that you will be updating patch 2 in the series for __FILE__ anyway so it's not like adding a useless code churn to do so. Thanks.