From: Junio C Hamano <gitster@pobox.com>
Date: Tue, 06 Mar 2012 20:19:06 GMT
Subject: Re: [msysGit] [PATCH] fix deletion of .git/objects sub-directories in git-prune/repack
Message-ID: <7v4nu1scsl.fsf@alter.siamese.dyndns.org>
In-Reply-To: <4F565849.80303@kdbg.org>

Johannes Sixt <j6t@kdbg.org> writes:

>> diff --git a/builtin/prune-packed.c b/builtin/prune-packed.c
>> index f9463de..a834417 100644
>> --- a/builtin/prune-packed.c
>> +++ b/builtin/prune-packed.c
>> @@ -36,7 +36,6 @@ static void prune_dir(int i, DIR *dir, char *pathname, 
>> int len, int opts)
>>                 display_progress(progress, i + 1);
>>         }
>>         pathname[len] = 0;
>> -       rmdir(pathname);
>
> After moving the rmdir() away from prune_dir(), the truncation of the
> pathname does not logically belong here anymore. It should be moved with
> the rmdir(). Looks good otherwise.

I agree that it is better to have the NUL termination close to where
it actually matters.

Do you want me to take it after locally fixing it up, or do you
prefer to feed this as part of msysgit related updates to me later?