From: Junio C Hamano <gitster@pobox.com>
Date: Mon, 02 Apr 2012 19:34:56 GMT
Subject: Re: [PATCH v3 3/4] fetch-pack: test cases for the new --stdin option
Message-ID: <7v4nt2exlr.fsf@alter.siamese.dyndns.org>
In-Reply-To: <4F79C2C8.3020009@gmx.net>

Ivan Todoroski <grnch@gmx.net> writes:

> +test_expect_success 'setup tests for the --stdin parameter' '
> +	for head in C D E F
> +	do
> +		add $head
> +	done &&
> +	for head in A B C D E F
> +	do
> +		git tag $head $head
> +	done
> +	cat >input <<EOF
> +refs/heads/C
> +refs/heads/A
> +refs/heads/D
> +refs/tags/C
> +refs/heads/B
> +refs/tags/A
> +refs/heads/E
> +refs/tags/B
> +refs/tags/E
> +refs/tags/D
> +EOF
> +	sort <input >expect
> +	(
> +	echo refs/heads/E &&
> +	echo refs/tags/E &&
> +	cat input
> +	) >input.dup
> +'


This breaks && chain; also it is easier to read if indentation is used
properly.

I'll queue it after fixing the above locally (the rest looked OK to me).

Thanks.