From: Junio C Hamano Date: Fri, 06 Apr 2012 06:55:18 GMT Subject: Re: [PATCH 1/5] argv-array: Add argv_array_pop function [v2] Message-ID: <7v4nsx2vu1.fsf@alter.siamese.dyndns.org> In-Reply-To: <20120406022058.GA16264@sigill.intra.peff.net> Jeff King writes: > So from the maintainer's and the project's perspective, those cc lines > are useless noise. > ... > So it is a piece of information that is useful to the submitter, but not > to the maintainer. ... nor the user of the project history, as you said earlier. I agree that submitters would benefit from an automated way to propagate these addresses from reroll to reroll, and in a larger workflow "tweak and record while amending a commit for reroll" would be a natural place to do so, so I can see why it is tempting to abuse Cc: in the body of the message, but not knowing other ways is not a good excuse for such an abuse. A workable solution is already available [*1*]: commit with a "---" line followed by Cc: and whatever extra junk while amending. Even if it did not work to write "---" before the extra Cc:, I do not think it is such a big deal, though. As the output file from format-patch is meant to be read into an editor for final proof-reading, it shouldn't be too much extra burden to move those Cc: at the end of the log message to the header part of the message while doing so anyway. [Footnote] *1* Here is a trivial demonstration. I amended the 1.7.10-rc4 on a throw-away branch to make "git show -s" show this: -- >8 -- commit aaac56582ce1820551d48bf2b2364cb00f0345cb Author: Junio C Hamano Date: Tue Apr 3 09:25:49 2012 -0700 Git 1.7.10-rc4 Signed-off-by: Junio C Hamano --- Cc: Test user This is a cover letter for small one. -- 8< -- Feeding output from "git format-patch -1 HEAD" for this patch to send-email does add the "Test user" to the list of recipients, like so: -- >8 -- 0001-Git-1.7.10-rc4.txt (body) Adding cc: Test user from line 'Cc: Test user ' Dry-OK. Log says: Sendmail: /usr/bin/msmtp -f gitster@pobox.com -i git@vger.kernel.org junio@pobox.com From: Junio C Hamano To: git@vger.kernel.org Cc: Test user Subject: [PATCH] Git 1.7.10-rc4 Date: Thu, 5 Apr 2012 23:47:09 -0700 Message-Id: <1333694829-4295-1-git-send-email-gitster@pobox.com> X-Mailer: git-send-email 1.7.10.rc4.54.g1d5dd3 Result: OK -- 8< --