From: Junio C Hamano Date: Tue, 01 May 2012 04:41:02 GMT Subject: Re: XDL_FAST_HASH breaks git on OS X 10.7.3 Message-ID: <7v4ns0cy3l.fsf@alter.siamese.dyndns.org> In-Reply-To: <7v8vhccy6m.fsf@alter.siamese.dyndns.org> Junio C Hamano writes: > Brian Gernhardt writes: > >> On Apr 30, 2012, at 12:38 PM, Thomas Rast wrote: >> >>> I can reproduce this. The problem is that __WORDSIZE is not defined, >>> either because it's Darwin or because the GCC is too old. It winds up >>> compiling the 32-bit case, which of course doesn't work for 64-bit >>> builds. >> >> Great. I was worried about having to help you debug it via e-mail round-trips. :-D >> >>> Perhaps we can rewrite it in terms of sizeof(long) like this? >> >> It does work for me, and seems pretty valid to me since long is actually >> the type you're storing it in. > > Thomas, care to roll an incremental update with proper log message, so > that we can unbreak the tip of 'next' for Darwin users? > > Thanks, both. Oh, one thing I forgot to say. The low-level code structure seems to become different, so the perf numbers may need to be measured again.