From: Junio C Hamano <gitster@pobox.com>
Date: Wed, 23 May 2012 14:54:41 GMT
Subject: Re: [PATCH 2/2] completion: split __git_ps1 into a separate script
Message-ID: <7v4nr72bim.fsf@alter.siamese.dyndns.org>
In-Reply-To: <4FBC0019.6030702@in.waw.pl>

Zbigniew Jędrzejewski-Szmek  <zbyszek@in.waw.pl> writes:

> On 05/22/2012 10:46 PM, Felipe Contreras wrote:
>>  contrib/completion/git-completion.bash |  257 +---------------------------
>>  contrib/completion/git-prompt.sh       |  287 ++++++++++++++++++++++++++++++++
>>  t/t9903-bash-prompt.sh                 |    2 +-
>>  3 files changed, 290 insertions(+), 256 deletions(-)
>>  create mode 100644 contrib/completion/git-prompt.sh
> Hi,
> since git-prompt is not completion related anymore, should a different
> directory be used?

I am not sure if that is worth it.  These two share/duplicate some shell
functions and we may end up refactoring them (a way to do so may be to
dot-source git-prompt from git-completion and drop duplicated definitions
from the latter), for example.