From: Junio C Hamano <gitster@pobox.com>
Date: Thu, 07 Jun 2012 17:11:47 GMT
Subject: Re: [PATCH] Introduce --current option to git-branch builtin command.
Message-ID: <7v4nqnjbcc.fsf@alter.siamese.dyndns.org>
In-Reply-To: <4FD069A5.1040905@lyx.org>

Vincent van Ravesteijn <vfr@lyx.org> writes:

> git-branch has four modes: 'list', 'create', 'delete', and
> rename'. Isn't --current then just another option to the 'list'-mode?

That is how I would look at it.  We can think of various ways that
"list" can be filtered, and matching by name is one that we have an
implementation for.  "Current-only" could be another one.

> If '--current' implies the 'list'-mode, it would use
> print_ref_list'. There already is code in print_ref_list to detect
> whether a branch is the current one, it outputs the branch list in a
> formatted way, it takes care of 'columns', so wouldn't it be better to
> modify that code to only print the current branch ?

Exactly.