From: Junio C Hamano Date: Mon, 20 Aug 2012 22:02:43 GMT Subject: Re: [PATCH] precompose-utf8: do not call checks for non-ascii "utf8" Message-ID: <7v4nnxjk70.fsf@alter.siamese.dyndns.org> In-Reply-To: <5032940A.4040005@web.de> Torsten Bögershausen writes: > a) in readdir we die() when iconv_open() fails, and we could/should do > that in void precompose_argv() as well? Probably. > b) Should die("txt") be converted into die(_("txt")) to be able to > translate the message? I do not even know what die("txt") is trying to tell to English-speaking users, so I dunno ;-). The message needs to be updated to human readable form and then annotated with _(), I guess.