From: Junio C Hamano Date: Mon, 17 Dec 2012 04:31:06 GMT Subject: Re: [PATCH v2 1/2] Makefile: remove tracking of TCLTK_PATH Message-ID: <7v4njlpaet.fsf@alter.siamese.dyndns.org> In-Reply-To: <20121216193850.23461.28099.chriscool@tuxfamily.org> Christian Couder writes: > It looks like we are tracking the value of TCLTK_PATH in the main > Makefile for no good reason, as this is done in git-gui too and the > GIT-GUI-VARS is not used in the Makefile. This was added to the main Makefile when we slurped gitk to our project at the top-level, so I am not surprised if git-gui were not depending on it at all. A better explanation is that t62ba514 (Move gitk to its own subdirectory, 2007-11-17) should have moved these lines to gitk-git/Makefile (and I think we should move them there in a separate patch).