From: Junio C Hamano Date: Thu, 07 Feb 2013 18:03:43 GMT Subject: Re: [RFC/PATCH 4/4] grep: obey --textconv for the case rev:path Message-ID: <7v4nho9f28.fsf@alter.siamese.dyndns.org> In-Reply-To: <5113827A.40801@drmicha.warpmail.net> Michael J Gruber writes: >>> (cd t && git grep GET_SHA1_QUIETLY HEAD:../cache.h) >>> ../HEAD:../cache.h:#define GET_SHA1_QUIETLY 01 >> >> Yuck. > > And even more yuck: > > (cd t && git grep --full-name GET_SHA1_QUIETLY HEAD:../cache.h) > HEAD:../cache.h:#define GET_SHA1_QUIETLY 01 > > Someone does not expect a "rev:" to be in there, it seems ;) I think stepping outside of $(cwd) is an afterthought the code does not anticipate.