From: Junio C Hamano Date: Mon, 04 Mar 2013 00:05:14 GMT Subject: Re: [PATCH v2 2/5] Help.c use OPT_COUNTUP Message-ID: <7v4ngsyqpx.fsf@alter.siamese.dyndns.org> In-Reply-To: "Philip Oakley" writes: >> Hrm, I do not recall anybody ever declared that "--all" is deprecated. > > No, it was the use OPT_COUNTUP rather than OPT_BOOLEAN that the > deprecated' was refering to. Oh, no OPT_BOOLEAN was deprecated because too many people rightfully thought it was about 0/1 choice and got burned by its count-up behaviour. When you want to count-up, OPT_COUNTUP is the right thing to do and replacing deprecated BOOLEAN with it is a correct thing to do. But for this optoin, I do not think you want to count up in the first place. You want a 0/1 choice, which is written as OPT_BOOL these days.