From: Junio C Hamano Date: Mon, 01 Apr 2013 18:10:10 GMT Subject: Re: [PATCH v2 05/12] pretty: save commit encoding from logmsg_reencode if the caller needs it Message-ID: <7v4nfqjf5p.fsf@alter.siamese.dyndns.org> In-Reply-To: <1364636112-15065-6-git-send-email-pclouds@gmail.com> Nguyễn Thái Ngọc Duy writes: > The commit encoding is parsed by logmsg_reencode, there's no need for > the caller to re-parse it again. The reencoded message now has the new > encoding, not the original one. The caller would need to read commit > object again before parsing. > > Signed-off-by: Nguyễn Thái Ngọc Duy > --- This and 06/12 look like a fix independent from the remainder of the series. Can they be moved a lot earlier in the series?