From: Junio C Hamano Date: Tue, 23 Apr 2013 14:01:51 GMT Subject: Re: [PATCH] Add .gitconfig variable commit.gpg-sign Message-ID: <7v4nexmjlc.fsf@alter.siamese.dyndns.org> In-Reply-To: <7vip3em8rs.fsf@alter.siamese.dyndns.org> Junio C Hamano writes: > Joel Jacobson writes: > >> Signed-off-by: Joel Jacobson >> --- >> builtin/commit.c | 4 +++- > > No docs? No tests? > > As to the design, any regular configuration variable settings must > be overridable from the command line for a single invocation. Please > design an escape hatch in, for somebody who has this configuration > variable set, but does not want to sign this commit he is about to > make. > > Also do we generally use dash in the configuration variable names? > I thought the norm was section.CamelCase. Another design issue you would need to consider before deciding to add such a configuration is how it interacts with "git rebase -i". The command internally runs "git commit --amend", etc. and I do not know if _all_ users who set this configuration want to unconditionally always re-sign all these commits. There may be other commands that internally use "git commit" that may be affected with such a configuration variable.