From: Junio C Hamano <gitster@pobox.com>
Date: Tue, 09 Jul 2013 05:38:11 GMT
Subject: Re: [PATCH] cache.h: move remote/connect API out of it
Message-ID: <7v4nc4xph8.fsf@alter.siamese.dyndns.org>
In-Reply-To: <20130709042106.GC27903@sigill.intra.peff.net>

Jeff King <peff@peff.net> writes:

> On Mon, Jul 08, 2013 at 02:09:59PM -0700, Junio C Hamano wrote:
>
>> The definition of "struct ref" in "cache.h", a header file so
>> central to the system, always confused me.  This structure is not
>> about the local ref used by sha1-name API to name local objects.
>> [...]
>>  * I hate to to this kind of code-movement in the middle of the
>>    cycle, but every time I follow the push->transport codepath, I
>>    become disoriented by these "struct ref"s.
>
> FWIW, this has often bugged me, too. I did not check what fallouts this
> will have for series in flight, but in general, I think it is a good
> thing to be doing.

The fallout can be seen at the tip of 'pu', which is fairly minimum
at the moment.