From: Junio C Hamano Date: Wed, 25 May 2005 01:49:20 GMT Subject: Re: [PATCH] diff-cache path restriction fix. Message-ID: <7v3bscqdlr.fsf@assigned-by-dhcp.cox.net> In-Reply-To: >>>>> "LT" == Linus Torvalds writes: LT> I checked in the fixed arg parsing already ;) Thanks. LT> Hmm. According to that logic, ">" and ">=" is superfluous. Yes, I was trained by Paul Eggert (me says that proudly). Practically speaking, the only time I deliberately used > and >= was when I was doing some dialect of SQL that always wanted literal on fixed side and column on the other; I do not remember which was which and whose SQL anymore. Of course I sometimes end up using them when I am trying to match the style of existing code. However, for that particular comparison in diff-cache, there weren't any other around there to match, other than the "if (argc < 2 || ...)" after the loop, which was what I myself wrote so it does not count. LT> Also, what language do you actually speak? Japanese. I have not thought about that kind of relationship between the natural language and if() expression at all, and I am certainly not claiming comparing it the logic way is natural in Japanese. I think it probably isn't. LT> ... Usually google is a good way to get a feel for how LT> common some phrase is, but not on things like this. If you feel strongly about this, just write it in coding-style document and I'll follow whatever you tell me while I am coding for this project. Honestly, I do not particularly care how common that is in the wider world outside.