From: Junio C Hamano <junkio@cox.net>
Date: Wed, 21 Sep 2005 19:45:13 GMT
Subject: Re: [PATCH 1/8] fetch.c: Remove useless lookup_object_type() call in process()
Message-ID: <7v3bnyurw6.fsf@assigned-by-dhcp.cox.net>
In-Reply-To: <20050921161855.896F1E010FC@center4.mivlgu.local>

Sergey Vlasov <vsu@altlinux.ru> writes:

> In all places where process() is called except the one in pull() (which
> is executed only once) the pointer to the object is already available,
> so pass it as the argument to process() instead of sha1 and avoid an
> unneeded call to lookup_object_type().

Agreed, except we probably would want to pass the expected type
to process() so that we can make sure the object is of that type,
perhaps?

Having said that, I am really happy that you seem to have fixed
it a lot better than my previous attempt, after which I was
really dissapointed that 'git clone' was still unusablly slow,
just walking commits in huge packs.

Thanks.