From: Junio C Hamano <junkio@cox.net>
Date: Thu, 09 Feb 2006 19:41:36 GMT
Subject: Re: gitweb using "--cc"?
Message-ID: <7v3bisb9qn.fsf@assigned-by-dhcp.cox.net>
In-Reply-To: <Pine.LNX.4.64.0602091029310.2458@g5.osdl.org>

I was wondering if we could teach not diff_tree_combined_merge
but show_combined_diff to do this, so that diff-files -c would
benefit from the raw output as wel.

That aside, one remaining nit with your patch is printing
p->path.  diff.c::diff_flush_raw() does something like this:

	if (line_termination) {
		path_one = quote_one(path_one);
		path_two = quote_one(path_two);
	}
	...
	printf("%s%c%s", status, inter_name_termination, path_one);

But otherwise from a cursory look the patch appears correct.

Thanks.