From: Junio C Hamano Date: Sun, 09 Apr 2006 19:08:36 GMT Subject: Re: [PATCH] git log [diff-tree options]... Message-ID: <7v3bgmbm8b.fsf@assigned-by-dhcp.cox.net> In-Reply-To: Linus Torvalds writes: > Well, on the other hand, the new "git log --diff" should get the revision > counting right even if it's _not_ done by the caller. Not if the user uses --diff-filter and/or --pickaxe, and after we start omitting the log message part when no diff is output. > So I'd suggest: > - drop git-whatchanged entirely > - keep it - for historical reasons - as a internal shorthand, and just > turn it into "git log --diff -cc" > > and everybody will be happy (yeah, it will show a few merge commits > without diffs, because the diffs end up being uninteresting, but that's > _fine_, even if it's not 100% the same thing git-whatchanged used to do) I tend to agree. A merge commit touching a path but not actually changing the contents of the path from parents might be a significant event.