From: Junio C Hamano Date: Mon, 11 Sep 2006 06:03:30 GMT Subject: Re: [PATCH 0/2] Command preparation cleanup in "connect.c" Message-ID: <7v3bazndn1.fsf@assigned-by-dhcp.cox.net> In-Reply-To: <200609110643.13486.chriscool@tuxfamily.org> Christian Couder writes: > The following two patches clean "connect.c" up using "add_to_string" > from "rsh.c". The code is still longer, but there is no leak and it may be > better to die with an error message than to truncate a too long command. Nice, clean, simple and obviously correct. Thanks.