From: Junio C Hamano <gitster@pobox.com>
Date: Wed, 30 Jan 2008 05:51:33 GMT
Subject: Re: [PATCH] filter-branch.sh: remove temporary directory on failure
Message-ID: <7v3asfkgii.fsf@gitster.siamese.dyndns.org>
In-Reply-To: <479E4612.6030006@nrlssc.navy.mil>

Brandon Casey <casey@nrlssc.navy.mil> writes:

> Even though this directory may be useful for debugging when you encounter
> a problem, I wonder if the normal "error" will be _user_ error. In which
> case the user will adjust the command line parameters and try to rerun.
> Currently the user would then receive the message
>
>      "$tempdir already exists, please remove it"
>
> Then, rm -rf the tempdir, then rerun.
>
> Is this necessary? Maybe anyone with the know-how to debug would also have the
> know-how to comment out the 'trap' in the script (or direct someone asking for
> help on the mailing list to do so).

Makes sense to me.  Dscho?