From: Junio C Hamano <junio@pobox.com>
Date: Tue, 13 May 2008 03:48:22 GMT
Subject: Re: [PATCH] Add a test for git-add --ignore-errors
Message-ID: <7v3aomx3sp.fsf@gitster.siamese.dyndns.org>
In-Reply-To: <20080512175848.GF3128@steel.home>

Alex Riesen <raa.lkml@gmail.com> writes:

> Signed-off-by: Alex Riesen <raa.lkml@gmail.com>
> ---
>  t/t3700-add.sh |    9 +++++++++
>  1 files changed, 9 insertions(+), 0 deletions(-)
>
> diff --git a/t/t3700-add.sh b/t/t3700-add.sh
> index 287e058..ca3e33d 100755
> --- a/t/t3700-add.sh
> +++ b/t/t3700-add.sh
> @@ -179,4 +179,13 @@ test_expect_success 'git add --refresh' '
>  	test -z "`git diff-index HEAD -- foo`"
>  '
>  
> +test_expect_success 'git add --ignore-errors' '
> +	git reset --hard &&
> +	date >foo1 &&
> +	date >foo2 &&
> +	chmod 0 foo2 &&
> +	git add --verbose --ignore-errors .
> +	git ls-files |grep foo1
> +'
> +
>  test_done

I like the fact that you added --ignore-errors and made it still error out
when it cannot read some files.  Shouldn't we be testing it here with
"must-fail"?