From: Junio C Hamano <gitster@pobox.com>
Date: Mon, 23 Jun 2008 22:11:11 GMT
Subject: Re: [RFC] Re: Convert 'git blame' to parse_options()
Message-ID: <7v3an3hke8.fsf@gitster.siamese.dyndns.org>
In-Reply-To: <alpine.LFD.1.10.0806231425270.2926@woody.linux-foundation.org>

Linus Torvalds <torvalds@linux-foundation.org> writes:

> On Mon, 23 Jun 2008, Pierre Habouzit wrote:
>> 
>>   Let's see if I can catch it elegantly.
>
> No.
>
> Look at builtin-blame.c.
>
> THEN get back to me.
>
> Trust me, you need what I wrote. Something that parses all the options in 
> one go, and ignores the ones it cannot parse, because a TOTALLY DIFFERENT 
> function than the caller will call it!

I do not think you two are saying vastly different things.

The series Pierre has just posted is prerequisite for teaching
parse_options() to queue the unknown ones (besides allowing a finer
grained stepwise parsing), so that the caller like cmd_blame() can call
revision parser with the remainder.