From: Junio C Hamano Date: Tue, 24 Jun 2008 07:39:40 GMT Subject: Re: [PATCH] clone: create intermediate directories of destination repo Message-ID: <7v3an3e0xv.fsf@gitster.siamese.dyndns.org> In-Reply-To: <20080624055022.GC19224@sigill.intra.peff.net> Jeff King writes: > The shell version used to use "mkdir -p" to create the repo path, but > the C version just calls "mkdir". Let's replicate the old behavior. In > this case we can simply create the directories leading up to the git > dir. If it's a bare repo, then that is everything that init_db wants > ahead of time. If it isn't bare, then the worktree contains the git dir, > so we create the worktree. Clever ;-) > The big difference is that safe_create_leading_directories will do an > adjust_shared_perm on the result. I don't think that should be a > problem, but it is a difference. This early in the code you would not have read anything that triggers "shared" so it probably is not a problem, I would think.