From: Junio C Hamano Date: Sat, 02 Aug 2008 16:42:11 GMT Subject: Re: email address handling Message-ID: <7v3alnpdwc.fsf@gitster.siamese.dyndns.org> In-Reply-To: <7vabfvpdyk.fsf@gitster.siamese.dyndns.org> Junio C Hamano writes: > Linus Torvalds writes: > >> On Sat, 2 Aug 2008, Johannes Schindelin wrote: >>> >>> Ah, there lies the rub (you forgot that the original complaint was about >>> a comma, and pretty=email does not handle those): >> >> Indeed. >> >> I wonder where that is_rfc2047_special() function came from. The list of >> "special" characters is totally bogus. > > This function is about quoting inside dq pair, so the function does not s/is about/is NOT about/; Sorry, I should grab coffee before continuing. > look at the set you listed. It is about quoting non-ascii chars using the > ?charset?Q? or ?charset?B? notation. > > If we want to use double quotes that should be done elsewhere, not in that > function.