From: Junio C Hamano <gitster@pobox.com>
Date: Wed, 10 Dec 2008 08:34:26 GMT
Subject: Re: [PATCH 2/2] diff: respect textconv in rewrite diffs
Message-ID: <7v3agw2zu5.fsf@gitster.siamese.dyndns.org>
In-Reply-To: <20081209081321.GA19707@coredump.intra.peff.net>

Jeff King <peff@peff.net> writes:

> Currently we just skip rewrite diffs for binary files; this patch makes
> an exception for files which will be textconv'd, and actually performs
> the textconv before generating the diff.
>
> Conceptually, rewrite diffs should be in the exact same format as the a
> non-rewrite diff, except that we refuse to share any context. Thus it
> makes very little sense for "git diff" to show a textconv'd diff, but
> for "git diff -B" to show "Binary files differ".

Makes sense.

> +cat >dump <<'EOF'
> +#!/bin/sh
> +perl -e '$/ = undef; $_ = <>; s/./ord($&)/ge; print $_' < "$1"
> +EOF

I'll squash in a change to make this part use $SHELL_PATH for
consistency.  Thanks.