From: Junio C Hamano <gitster@pobox.com>
Date: Sat, 20 Dec 2008 20:09:44 GMT
Subject: Re: [PATCH] git-send-email: handle email address with quoted comma
Message-ID: <7v3agiwquv.fsf@gitster.siamese.dyndns.org>
In-Reply-To: <loom.20081219T162504-25@post.gmane.org>

Matt Kraai <kraai@ftbfs.org> writes:

> Howdy,
>
> Wu Fengguang <fengguang.wu <at> intel.com> writes:
>> +sub split_addrs {
>> +	return parse_line('\s*,\s*', 1, @_);
>> +}
>> +
>
> I'm not sure it's still a good idea to use parse_line.  It should work OK for
> now, since split_addrs is only passed one string.  If anyone ever tries to pass
> it a list of strings, however, parse_line will ignore all but the first.

Yikes, I should have caught this.  As you point out, this is a breakage
waiting to happen until somebody restructures the callers.  We should
futureproof it by using quotewords() instead.