From: Junio C Hamano <gitster@pobox.com>
Date: Mon, 23 Feb 2009 16:33:47 GMT
Subject: Re: [PATCH 1/2] Make git blame's date output format configurable, like git log
Message-ID: <7v3ae5un84.fsf@gitster.siamese.dyndns.org>
In-Reply-To: <20090222230358.GA19011@coredump.intra.peff.net>

Jeff King <peff@peff.net> writes:

> On Fri, Feb 20, 2009 at 02:51:11PM -0800, eletuchy@gmail.com wrote:
>
>> @@ -1975,6 +1975,9 @@ static int git_blame_config(const char *var, const char *value, void *cb)
>>  		blank_boundary = git_config_bool(var, value);
>>  		return 0;
>>  	}
>> +	if (!strcmp(var, "blame.date") && value[0]) {
>> +		blame_date_mode = parse_date_format(value);
>> +	}
>>  	return git_default_config(var, value, cb);
>>  }
>
> When there is a config value we are expecting to have a value rather
> than a boolean, we usually print an error rather than silently
> discarding.

Oops, missed that.  Yes, this needs fixing.

Thanks.