From: Junio C Hamano <gitster@pobox.com>
Date: Thu, 04 Jun 2009 21:13:03 GMT
Subject: Re: [PATCH] diesys calls die and also reports strerror(errno)
Message-ID: <7v3aafwvmo.fsf@alter.siamese.dyndns.org>
In-Reply-To: <20090604205055.GB17478@sigill.intra.peff.net>

Jeff King <peff@peff.net> writes:

> Should we be calling malloc here? One of the possible error conditions
> is that we're out of memory (though xmalloc itself just uses "die"). I
> don't think there is a good reason not to use a reasonably-sized static
> buffer, which should increase robustness (report() is already using a
> 1024-character buffer, so any message would be truncated there anyway).

Yup, and at that point, tacking strerror value while expanding possible %
becomes even easier.